#377 Hunter Pet happiness randomly resets to its maximum value

Status: Awaiting review · Area: Classes & Specs · Hunter

A hunter pet's happiness randomly jumps to full, possibly linked to feeding it.

Current behavior

Hunter pet's happiness resets to its maximum value in random moments of time. Tested in the overworld and inside an instance (RFC). After extensive testing I found out that the problem is probably related to Feed Pet. I was able to reproduce this behavior by reducing pet's happiness to red level (by repeatably dismissing it), then feeding with a good quality food (+35 happiness per tick) until yellow level, then dismissing the pet and then calling it back. After 30-300 s of waiting time the happiness randomly sets to maximum. Possible related to #345

Expected behavior

Hunter's happiness decays slowly over time (this actually works properly) and does not randomly set itself to maximum value.

How to reproduce

1. Summon your pet
2. Dismiss it a number of times (e.g. 14 times) or let it die 2 times.
3. This will set the pet's happiness to Red level
4. Feed the pet once to get to Yellow level. Wait 20 seconds.
5. Dismiss the pet.
6. Call the pet. It should have Yellow happiness level.
7. Wait for a random amount of time (30s to 300s in my tests).
8. The pet's happiness randomly sets to maximum.
9. If nothing happens within 5 minutes then repeat points 5-7 until the bug is observed.
10. The happiness value can be evaluated by feeding the pet and observing the happiness increase in battle log -- when the pet has maximum happiness the feed pet does not generate happiness.