#278 Threat From Resource Generation Reduced/Incorrect

Status: Open · Area: Classes & Specs · Warrior

Gaining rage or using a mana potion generates much less threat than expected, which could hurt tanks holding aggro.

Current behavior

While trying to validate threat from rage consumables I noticed that I'm now getting significantly reduced threat from rage generation. I'm getting 3 threat on a +5 rage gain from block/dodge/parry on warrior. From a `rage potion I got 17 threat from a 27 rage proc`. This is while only engaged with a single target. I also engaged a second nearby target to ensure it wasn't being given some of the threat while not engaged and this did correctly then divide my reduced threat amongst the 2 targets. After a bit of testing on my hpal I'm also noticing odd threat from mana gains. I `mana potioned for 358 and generated 89 threat`. This is roughly half the expected threat so perhaps in my pallies case it divided threat onto a mob I was near but not in combat with, but I was definitely only in combat with 1 mob. If this is intentional, we are seeing a 50% reduction in threat gains from mana on ppal and a stagging 78% reduction on threat gains from resource generation from pwar. `1:0.5` -> `1:0.25` on ppal `1:5` -> `1:0.6` on war

Expected behavior

The expected values, and these I believe were correct outside of the cases noted in [This threat from resources/healing issues](https://github.com/ClassicWoWCommunity/forever-bugs/issues/66), are that I should get 5 threat per 1 rage generated. I am getting 3 threat per 5 rage on single target, and 1 threat per 5 rage on 2 target. a 358 mana potion should generate ~179 threat

How to reproduce

1. Pull 1 mob with some kind of threat viewer open
2. Use a rage potion
3. Compare the threat gained from the rage gains to the expected values 
4. Repeat with multi-combat 

** I was testing inside RFC, i don't think it relates but might be useful to know.