#257 Elemental Devastation does not trigger from DoT ticks, totems, or weapon imbues

Status: Fixed · Area: Classes & Specs · Shaman

Elemental Devastation only triggers on some spell crits, and not on Flame Shock ticks, Searing Totem or weapon imbues as the talent text implies.

Current behavior

Elemental Devastation only triggers from some offensive spell crits. Several damaging effects that can crit do not trigger it. Talent text (Elemental Combat, Tier 2): "Your offensive spell critical strikes will increase your chance to get a critical strike with melee attacks by 3/6/9% for 10 sec." For each ability below, I checked whether a critical hit applied the Elemental Devastation buff: | Ability | Triggers Elemental Devastation? | |---|---| | Lightning Bolt | Yes | | Earth Shock | Yes | | Frost Shock | Yes | | Flame Shock (initial damage) | Yes | | Flame Shock (periodic ticks) | **No** | | Searing Totem | **No** | | Fire Nova | **No** | | Flametongue Weapon | **No** | | Frostbrand Weapon | **No** | | Lightning Shield | N/A (could not get it to crit) |

Expected behavior

The talent says "offensive spell critical strikes" with no exceptions, so I expected the "No" abilities above to trigger it: - Periodic ticks can now crit, so Flame Shock ticks should count. - Searing Totem deals spell damage and can crit. Elemental Fury also lists Searing Totem by name as one of the spells it affects. - Fire Nova is an offensive Fire spell that can crit, and even though it is cast from the totem, the threat is transferred to the Shaman.

How to reproduce

1. Take 3 points in Elemental Devastation.
2. Cast each ability above on targets until it crits (higher chance to crit grey enemies).
3. Check for the buff or a change in melee crit chance.

Lightning Bolt and the shocks give the buff. The other abilities do not, even on crits.