#137 Inner Focus crit behaviour wrong

Status: Fixed · Area: Classes & Specs · Priest

Inner Focus behaves oddly with damage-over-time spells, giving 25% crit to ones already active instead of boosting the next spell.

Current behavior

Inner focus does not work properly with dynamic damage over time effects, which are capable of critting now. Any dot/hot will "lose track" of the supposed 25% extra crit by the time the first tick rolls out. Inner focus does not: "snapshot" 25% crit to the next spell cast if the spell in question is a DoT, HoT, (and possibly channel) However, flipping the script, and dotting first, then activating Inner Focus (without consuming it via spell cast) seems to dynamically give all active dots 25% crit chance for the indefinite window until we choose to consume inner focus. Inner focus does: Give an invisible +25% crit buff to all DoTs that have been placed prior to its activation In my tests, I tried minimizing natural crits, hence i am dotting naked with rez sickness (the lowest spell crit i could get to is 1.44%). At that crit chance, we expect one crit every 69.4 instances of damage. I dotted 3 monsters, used inner focus and observed 5 crits in 18 instances of damage instead. It is to be noted that this +25% crit does not seem to appear in the character sheet, or the tooltip for the crit stat in the character sheet.

Expected behavior

Inner Focus text reads: "When activated, reduces the Mana cost of your next spell by 100% and increases its critical effect chance by 25% if its capable of a critical effect" This is a little bit opinionated because Inner Focus is inherently incompatible with the new dot system's "no snapshotting" philosophy. Anyways, this is what I as a player would expect to happen upon reading the current text of inner focus: I would not expect for Inner focus to have a lingering invisible crit buff for dynamic dots to latch on to. I would expect consuming inner focus on a DoT/HoT to provide an increase of 25% crit over the duration. Thats how it should work according to the ability text, as DoTs are capable of critical effect now. If it was not intended for inner focus to work with over time effects, I would expect the spell to mention that.

How to reproduce

1. Get natural crit as low as possible, ideally 0 (optional for Signal to Noise ratio, not required for the bug itself)
2. DoT monsters (more DoTs give more samples per Inner Focus cast, here I use Rank 1 of Shadow Word: Pain)
3. Activate Inner Focus and refrain from casting spells after, as to not consume it
4. All in step (2) applied DoTs have now an amplified +25% crit chance
5. DoTs and other delayed effects like Touch of Weakness should be critting more often then expected now