#126 Offhand swing timer (actual time until swing, not UI swing timer) being improperly set to the offhand progress limit on weapon swap.

Status: Awaiting review · Area: Items & Loot · Weapons & Armor

Equipping an offhand weapon starts its swing timer partway through, making the offhand hit earlier than it should.

Current behavior

Note for this report that when I refer to the "swing timer" I'm referring to the internal swing timer determining when the actual swing will occur, **not** the UI that is displayed with the new "Enable Swing Timer" option. Whether or not that is accurate is a separate question. When equipping a weapon into your offhand slot, the offhand swing timer's progress seems to be automatically set to what I call the "Offhand Idle Limit" (~45% progress from start). This results in the offhand swing occurring earlier than it would if the swing timer had started from 0 on the weapon swap, as is the case for the mainhand swing timer. With a slow enough offhand, this can even mean that you can induce two offhand swings within a shorter duration than the total offhand swing timer by quickly swapping the offhand in less time than it would take to reach 45% progress.

Expected behavior

I expect that the intended functionality is for the offhand to be reset to 0% swing timer progress on a weapon change, just as the mainhand (and ranged in classic, though I have not tested ranged in forever) is. As evidence for this, I submit the fact that the new swing timer UI included in forever does fully reset the displayed offhand swing timer on a weapon change, which is then inaccurate due to the described behaviour.

How to reproduce

1. Attack a mob while dual-wielding.
2. Immediately after your offhand swing goes off, switch your offhand to a different offhand.
3. Observe that your following offhand swing will go off in less time than the full swing speed of the weapon.